Remove DEPENDS argument from add_custom_command(TARGET...) functions #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises a warning with recent CMake versions, and isn't required due to the `pico_add_link_depend` already added for these files Fixes raspberrypi/picotool#235
kilograham
approved these changes
May 30, 2025
|
Note, this probably explains why historically there were problem with various dependencies (as DEPENDS in this situation actually never did anything) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises a warning with recent CMake versions, and isn't required due to the
pico_add_link_dependalready added for these files in #2027Fixes raspberrypi/picotool#235