Skip to content

Conversation

markhermeling
Copy link
Contributor

Fixes #2520 my removing unnecessary escape '' characters.

@lurch
Copy link
Contributor

lurch commented Jun 16, 2025

CI is failing 🙁

CMake Error at cmake/generic_board.cmake:24 (if):
  if given arguments:

RegularExpression::compile(): Unmatched parentheses.
RegularExpression::compile(): Error in compile.
    "LINE" "MATCHES" "^[ 	]*pico_board_cmake_set[ 	]*\\([ 	]*([a-zA-Z_][a-zA-Z0-9_]*)[ 	]*,[ 	]*(.*)[ 	]*)[ 	]*"

  Regular expression "^[ 	]*pico_board_cmake_set[ 	]*\([
  	]*([a-zA-Z_][a-zA-Z0-9_]*)[ 	]*,[ 	]*(.*)[ 	]*)[ 	]*" cannot compile
Call Stack (most recent call first):
  cmake/pico_pre_load_platform.cmake:70 (include)
  pico_sdk_init.cmake:88 (include)
  CMakeLists.txt:8 (include)

@lurch
Copy link
Contributor

lurch commented Jun 16, 2025

I'm afraid it's still failing:

CMake Error at cmake/generic_board.cmake:24 (if):
  if given arguments:

    "LINE" "MATCHES" "^[ 	]*pico_board_cmake_set[ 	]*\\([ 	]*([a-zA-Z_][a-zA-Z0-9_]*)[ 	]*,[ 	]*(.*)[ 	]*)[ 	]*"

  Regular expression "^[ 	]*pico_board_cmake_set[ 	]*\([
  	]*([a-zA-Z_][a-zA-Z0-9_]*)[ 	]*,[ 	]*(.*)[ 	]*)[ 	]*" cannot compile
Call Stack (most recent call first):
  cmake/pico_pre_load_platform.cmake:70 (include)
  pico_sdk_init.cmake:88 (include)
  CMakeLists.txt:8 (include)

@lurch
Copy link
Contributor

lurch commented Jun 16, 2025

CI is now passing, so pinging @will-v-pi

@lurch lurch linked an issue Jun 16, 2025 that may be closed by this pull request
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks correct now - the only uneccessary escapes were the \] ones

@kilograham kilograham added this to the 2.1.2 milestone Jun 16, 2025
@kilograham kilograham merged commit a9851a1 into raspberrypi:develop Jun 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unneeded escape characters in cmake/generic_board.cmake

4 participants