-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add pioasm --version, and print version number in generated files #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is the change to @will-v-pi I wonder if it's worth having a CI job that builds a sample PIO file with each of the different output-formats that Also, after this PR is merged I guess we'll need to update the pioasm-generated headers in the pico-examples repo. |
|
||
header(out, "This file is autogenerated by pioasm; do not edit!"); | ||
std::stringstream header_string; | ||
header_string << "This file is autogenerated by pioasm version " << PIOASM_VERSION_STRING << "; do not edit!"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it might be worth also including the filename (with any directory-parts removed) of the input PIO file? e.g.
// This file is autogenerated from ws2812.pio by pioasm version 2.1.2; do not edit!
it was unintentional, but then again the file isn't really used for anything - we should have a regression test that checks the output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I will fix pico-sdk-tools to pass the new PIOASM_VERSION_STRING argument
fixes #2307