add missing libraries to test/kitchen_sink and auto-gen includes #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| target_link_libraries(kitchen_sink_libs INTERFACE ${LIB}) | ||
| string(REGEX MATCH "([a-z]+)_(.+)" HAS_MATCH ${LIB}) | ||
| if (HAS_MATCH AND NOT LIB IN_LIST KITCHEN_SINK_NO_HEADER_LIBS) | ||
| # these are few, so just hack fixing for now |
There was a problem hiding this comment.
Might be nice to fix these in future?
There was a problem hiding this comment.
yes, probably so, i almost added a pico/util.hbut decided against it at the time ;-)
peterharperuk
approved these changes
Jul 17, 2025
will-v-pi
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.