Skip to content

Fix location of map file on Ninja #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Fix location of map file on Ninja #2584

merged 1 commit into from
Jul 23, 2025

Conversation

will-v-pi
Copy link
Contributor

Switch to using CMake generator expressions to ensure the .elf.map file is in the same location as the .elf file.

Fixes #1753

@will-v-pi will-v-pi added this to the 2.2.0 milestone Jul 23, 2025
@will-v-pi will-v-pi requested a review from kilograham July 23, 2025 11:18
@lurch
Copy link
Contributor

lurch commented Jul 23, 2025

What a nice change to see a fix that actually makes the code simpler rather than more complex 🙂

@lurch lurch mentioned this pull request Jul 23, 2025
Closed
kilograham
kilograham approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet; why didn't i do that in the first place ;-)

@kilograham kilograham merged commit 9b876bb into develop Jul 23, 2025
11 checks passed
@kilograham kilograham deleted the map-loc-fix branch July 23, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kilograham kilograham kilograham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@will-v-pi @lurch @kilograham