Fix always-true comparison warning in pio_insn #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sideset_bit_count in pio_encode_sideset_opt is unsigned, so any comparison "sideset_bit_count >= 0" will always be true. GCC with pedantic warnings will complain when this happens. Remove the unneeded >=0 portion of the parameter validity check. Fixes raspberrypi#2607
kilograham
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sideset_bit_count in pio_encode_sideset_opt is unsigned, so "sideset_bit_count >= 0" will always be true. GCC with pedantic warnings will complain when this happens.
Remove the unneeded >=0 portion of the parameter validity check.
Fixes #2607