various floating point fixes#2849

Merged

kilograham merged 14 commits intodevelopfrom

Mar 6, 2026

Contributor

kilograham commented Mar 5, 2026 •

edited

Loading

fix issues with and improve tests for dcp conversions of INFINITES to fixed point values
fixes missing DCP state saves (fix Some functions in pico_float_pico_dcp do not check the coprocessor state #2793)


          fix issues with and improve tests for dcp conversions of INFINITES to…

34cb3de

… fixed point values

kilograham added this to the 2.2.1 milestone

kilograham requested a review from Wren6991

March 5, 2026 21:03

kilograham added 2 commits

March 5, 2026 15:11


          improve comments

61b949b


          fix outstanding todo in __aeabi_dmul via DCP which improves speed/size

c773c41

kilograham mentioned this pull request

Handle the missing DCP state in pico_float_pico_dcp #2794

Closed

kilograham changed the title ~~fix issues with and improve tests for dcp conversions of INFINITES to fixed point values~~ various floating point fixes

kilograham added 7 commits

March 5, 2026 16:02


          fix missing DCP state saves for float2int, float2uint and float2fix

3fbb8fd


          slightly improve implementation of saturation of INFINITES

32ebfa6


          should not include sf_table.h in double.h

0b7e8ae


          point out that float/double->fixed/int saturate in the docs

e3b0ede


          fix typo


          move some doxygen into RP2350 specific and change include guards ro b…

dd1f40e

…e RP2350 specific


          more doc tweaks

5ef1095

lurch added the floating point label

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

kilograham and others added 2 commits

March 6, 2026 09:01


          fixup check names to be more consistent

d9827b9

Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>


          more check naming fixes

8db0034

Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved


          and even more check names

b7cf048

Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>

lurch reviewed

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

kilograham commented

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

kilograham commented

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

kilograham commented

View reviewed changes

test/pico_float_test/custom_float_funcs_test.c Outdated Show resolved Hide resolved


          fix signedness of a few checks

1e40e42

kilograham merged commit 47226c6 into develop

11 checks passed

kilograham deleted the float_fixes branch

March 6, 2026 19:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels