Skip to content

clean up some inefficient (looking) code #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Fix typo in README.md "block loop if ELF files" in picotool create raspberrypi#194
merged 2 commits into from
May 29, 2025
Merged

clean up some inefficient (looking) code #234

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c5c6b
clean up some inefficient (looking) code
kilograham May 14, 2023
0652554
review fixes
kilograham May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,20 +1726,15 @@ struct memory_access {
// write a vector of types that have a raw_type_mapping
template <typename T> void write_vector(uint32_t addr, vector<T> &v) {
assert(v.size());
vector<typename raw_type_mapping<T>::access_type> buffer(v.size());
for(const auto &e : v) {
buffer.push_back(e);
}
write(addr, (uint8_t *)buffer.data(), v.size() * sizeof(typename raw_type_mapping<T>::access_type));
write(addr, (uint8_t *)v.data(), v.size() * sizeof(typename raw_type_mapping<T>::access_type));
}

template <typename T> void read_into_vector(uint32_t addr, unsigned int count, vector<T> &v, bool zero_fill = false) {
vector<typename raw_type_mapping<T>::access_type> buffer(count);
if (count) read(addr, (uint8_t *)buffer.data(), count * sizeof(typename raw_type_mapping<T>::access_type), zero_fill);
v.clear();
v.reserve(count);
for(const auto &e : buffer) {
v.push_back(e);
// vector<typename raw_type_mapping<T>::access_type> buffer(count);
if (count) {
v.clear();
v.resize(count);
read(addr, (uint8_t *)v.data(), count * sizeof(typename raw_type_mapping<T>::access_type), zero_fill);
}
}
};
Expand Down
Loading