Fix the error message for config signing #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user runs rpi-eeprom-config to sign a bootloader image, if the image is not the correct size, the error message returns a tautology: rpi-eeprom-config -c boot.conf -p /tmp/rpi-pubkey.pem \ -o pieeprom.upd /tmp/downloaded-boot.img ERROR: /tmp/downloaded-boot.img: \ Expected size 62914560 bytes actual size 62914560 bytes When it should be alerting the user that there are only two valid values for a bootloader size. My MR addresses this issue by returning the acceptable values for the bootloader size in the image. ./rpi-eeprom-config -c boot.conf -p /tmp/rpi-pubkey.pem \ -o pieeprom.upd /tmp/downloaded-boot.img ERROR: /tmp/downloaded-boot.img: \ Expected sizes [524288, 2097152] bytes, got actual size 62914560 bytes Signed-off-by: Lincoln Thurlow <[email protected]>
Collaborator
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user runs rpi-eeprom-config to sign a bootloader image, if the image is not the correct size, the error message returns a tautology:
When it should be alerting the user that there are only two valid values for a bootloader size. My MR addresses this issue by returning the acceptable values for the bootloader size in the image.