Skip to content

Commit 1e2169a

Browse files
lurchpelwell
authored andcommitted
Minor pinctrl optimisation: don't call gpio_get_level twice
1 parent 4f4c174 commit 1e2169a

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

pinctrl/pinctrl.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ static int do_gpio_get(unsigned int gpio)
121121
unsigned int num = gpio;
122122
const char *name;
123123
int fsel;
124+
int level;
124125

125126
if (pin_mode)
126127
{
@@ -153,9 +154,11 @@ static int do_gpio_get(unsigned int gpio)
153154
if (pin_mode && strchr(name, '/'))
154155
name = strchr(name, '/') + 1;
155156

157+
level = gpio_get_level(gpio);
158+
156159
printf(" %s | %s // %s%s%s\n",
157160
gpio_get_pull_name(gpio_get_pull(gpio)),
158-
(gpio_get_level(gpio) == 1) ? "hi" : (gpio_get_level(gpio) == 0) ? "lo" : "--",
161+
(level == 1) ? "hi" : (level == 0) ? "lo" : "--",
159162
name ? name : "",
160163
name ? " = " : "",
161164
gpio_get_gpio_fsel_name(gpio, fsel));

0 commit comments

Comments
 (0)