Move wipe_devices lambda string dispatch to C++ to save ESP8266 RAM#554
Merged
Move wipe_devices lambda string dispatch to C++ to save ESP8266 RAM#554
Conversation
Move the string-to-PairedDevice mapping out of the YAML lambda and into
a C++ overload of clear_paired_devices(const std::string&). The lambda
had 5 string literals that ended up in RODATA (RAM on ESP8266). The new
implementation uses length + first character checks which avoids any
string data in RAM.
The behavior is functionally the same — all valid inputs ("all",
"remote", "keypad", "wall", "accessory") map to the same enum values.
The matching is slightly more permissive since it checks length and
first character rather than exact equality, but invalid values are
never sent through the HA service in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PairedDevicemapping from the YAML lambda into a C++ template method onRATGDOComponentstd::stringandStringRef(or any type withlength()andoperator[])all,remote,keypad,wall,accessory) map to the same enum values, just slightly more permissive since it checks length and first character rather than exact equality