Add 'Beep on arrival' toggle for ratgdo32-disco boards#560
Open
mav2287 wants to merge 3 commits intoratgdo:mainfrom
Open
Add 'Beep on arrival' toggle for ratgdo32-disco boards#560mav2287 wants to merge 3 commits intoratgdo:mainfrom
mav2287 wants to merge 3 commits intoratgdo:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Contributor
|
Build failure has to be fixed before this can be merged. |
Wrap RATGDO_BEEP_ON_ARRIVAL switch cases with #ifdef RATGDO_USE_VEHICLE_SENSORS guards to match the conditional compilation of set_beep_on_arrival(), get_beep_on_arrival(), and subscribe_beep_on_arrival() in ratgdo.h/ratgdo.cpp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@PaulWieland should be good now, take a look and let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ratgdo.h/ratgdo.cpp— Addbeep_on_arrivalobservable, getter/setter, and subscribe method (insideRATGDO_USE_VEHICLE_SENSORSguard)switch/ratgdo_switch.h/ratgdo_switch.cpp/__init__.py— AddRATGDO_BEEP_ON_ARRIVALswitch type with preference persistenceoutput/ratgdo_output.cpp— Gate the vehicle arrival beep onget_beep_on_arrival()Test plan
🤖 Generated with Claude Code