Delete buffers after the window has closed#263
Merged
ravitemer merged 3 commits intoravitemer:mainfrom Jan 15, 2026
Merged
Conversation
THe confirmation buffers are unlisted, but never deleted.
These buffers configured with "bufhidden" "wipe", which should clean them up after the buffer is hidden anyway. This is just an extra check to be sure they are cleaned up.
Owner
|
Thanks for fixing this! |
lattenwald
pushed a commit
to lattenwald/mcphub.nvim
that referenced
this pull request
Jan 18, 2026
* fix: Delete confirmation window buffers after closing. THe confirmation buffers are unlisted, but never deleted. * fix: Delete auth popup window buffers after closing. * Explicitly delete multiline_input buffers after closing. These buffers configured with "bufhidden" "wipe", which should clean them up after the buffer is hidden anyway. This is just an extra check to be sure they are cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a long session of AI assisted activities, I noticed quite a few hidden buffers still open from MCPHub for all of the confirmation windows. Not a huge performance problem, but it makes it clutters the hidden buffers menus and makes it harder to find the actual hidden buffers I might be looking for. Since these buffers are not used again, it's a bit of a memory leak to not clean them up.
Checklist
make testto ensure all tests passmake formatto format the codemake docsto update the vimdoc pages