Upgrade gleam_erlang and gleam_otp; much simpler event decoders#5
Open
keroami wants to merge 7 commits intorawhat:masterfrom
Open
Upgrade gleam_erlang and gleam_otp; much simpler event decoders#5keroami wants to merge 7 commits intorawhat:masterfrom
keroami wants to merge 7 commits intorawhat:masterfrom
Conversation
added 7 commits
November 8, 2025 09:12
rawhat
requested changes
Nov 14, 2025
Owner
rawhat
left a comment
rawhat
left a comment
There was a problem hiding this comment.
awesome, thank you for doing this! i don't honestly know if this library should really even exist at this point, especially with how unpleasant it is to actually get the crossterm binary after installing it. but probably still valuable for this to be up-to-date
| init_timeout: 500, | ||
| loop: spec.loop, | ||
| )) | ||
| init, |
Owner
There was a problem hiding this comment.
could you add a type annotation here?
| |> actor.start | ||
| } | ||
|
|
||
| pub fn do_listen() { |
Owner
There was a problem hiding this comment.
i think this should probably use the new factory supervisor but can do that later. does this need to be public?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope you find this useful!
Kero
(McNimble at discrod)