Skip to content

[Helm] Add priorityClassName for kuberay-operator chart #3703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[Helm] Add priorityClassName for kuberay-operator chart #3703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bcd403
Add priorityClassName for operator helm chart
win5923 May 28, 2025
d8b53bf
Add test
win5923 Jun 27, 2025
6adfaee
Merge branch 'master' into helm-CRD-outside
win5923 Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions helm-chart/kuberay-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,13 @@ spec:
| image.repository | string | `"quay.io/kuberay/operator"` | Image repository. |
| image.tag | string | `"nightly"` | Image tag. |
| image.pullPolicy | string | `"IfNotPresent"` | Image pull policy. |
| imagePullSecrets | list | `[]` | Secrets with credentials to pull images from a private registry |
| nodeSelector | object | `{}` | Restrict to run on particular nodes. |
| priorityClassName | string | `""` | Pod priorityClassName |
| labels | object | `{}` | Extra labels. |
| annotations | object | `{}` | Extra annotations. |
| affinity | object | `{}` | Pod affinity |
| tolerations | list | `[]` | Pod tolerations |
| serviceAccount.create | bool | `true` | Specifies whether a service account should be created. |
| serviceAccount.name | string | `"kuberay-operator"` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template. |
| logging.stdoutEncoder | string | `"json"` | Log encoder to use for stdout (one of `json` or `console`). |
Expand Down
3 changes: 3 additions & 0 deletions helm-chart/kuberay-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ spec:
securityContext:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.priorityClassName }}
priorityClassName: {{ . }}
{{- end }}
containers:
- name: {{ .Chart.Name }}
{{- with .Values.securityContext }}
Expand Down
8 changes: 8 additions & 0 deletions helm-chart/kuberay-operator/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,14 @@ tests:
operator: Exists
effect: NoSchedule

- it: Should add priorityClassName if `priorityClassName` is set
set:
priorityClassName: high-priority
asserts:
- equal:
path: spec.template.spec.priorityClassName
value: high-priority

- it: Should use custom reconcile concurrency when set
set:
reconcileConcurrency: 5
Expand Down
15 changes: 15 additions & 0 deletions helm-chart/kuberay-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,27 @@ image:
# -- Image pull policy.
pullPolicy: IfNotPresent

# -- Secrets with credentials to pull images from a private registry
imagePullSecrets: []

# -- Restrict to run on particular nodes.
nodeSelector: {}

# -- Pod priorityClassName
priorityClassName: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/

kubectl apply -f - <<EOFapiVersion: scheduling.k8s.io/v1                
kind: PriorityClass
metadata:
  name: high-priority
value: 1000000
globalDefault: false
description: "This priority class should be used for XYZ service pods only."
EOF

helm install kuberay-operator --set priorityClassName="high-priority"  ../helm-chart/kuberay-operator

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also add a test in https://github.com/ray-project/kuberay/blob/master/helm-chart/kuberay-operator/tests/deployment_test.yaml?

Copy link
Contributor Author

@win5923 win5923 Jun 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added the test in d8b53bf.


# -- Extra labels.
labels: {}

# -- Extra annotations.
annotations: {}

# -- Pod affinity
affinity: {}

# -- Pod tolerations
tolerations: []

serviceAccount:
# -- Specifies whether a service account should be created.
create: true
Expand Down
Loading