Skip to content

Conversation

machichima
Copy link
Contributor

@machichima machichima commented Jun 13, 2025

  • Use a Golang-native way to get/create/delete some ray and core resources. (e.g. Ray().RayV1().RayClusters(namespace).List())

Why are these changes needed?

Currently, kubectl-plugin uses kubectl command to get results for testing. We should use a more Golang native solution to get K8s resources.

cmd = exec.Command("kubectl", "get", "--namespace", namespace, "rayjob", "rayjob-sample", "-o", "jsonpath={.status.jobId}")

Related issue number

Closes #3626

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@machichima machichima changed the title 3626 golang retrieve cr status [kubectl-plugin] Use a more Golang-native approach to retrieve the CR status for testing Jun 14, 2025
@machichima machichima marked this pull request as ready for review June 14, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kubectl-plugin] Use a more Golang-native approach to retrieve the CR status for testing
3 participants