[Bug][RayJob] Sidecar mode shouldn't restart head pod when head pod is deleted #4234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s deleted Signed-off-by: 400Ping <[email protected]>
400Ping
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
Signed-off-by: 400Ping <[email protected]>
Contributor
Author
|
cc @Future-Outlier @rueian PTAL |
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
Hi, @400Ping
let us know if you need any help, plz ping us
Contributor
Author
|
Ok, will do thanks. |
Signed-off-by: 400Ping <[email protected]>
rueian
reviewed
Dec 16, 2025
Signed-off-by: 400Ping <[email protected]>
Signed-off-by: 400Ping <[email protected]>
Signed-off-by: 400Ping <[email protected]>
400Ping
force-pushed
the
bug/sidecar-mode-fix
branch
from
b8077b9 to
c4bfd24
Compare
Signed-off-by: 400Ping <[email protected]>
Signed-off-by: 400Ping <[email protected]>
rueian
reviewed
Dec 21, 2025
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
400Ping
force-pushed
the
bug/sidecar-mode-fix
branch
from
81a9ee0 to
33afa20
Compare
Signed-off-by: 400Ping <[email protected]>
Signed-off-by: 400Ping <[email protected]>
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
cc @machichima @seanlaii to do the final pass for the test
Signed-off-by: 400Ping <[email protected]>
CheyuWu
approved these changes
Jan 3, 2026
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
approved these changes
Jan 4, 2026
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
LGTM, thank you
cc @rueian @andrewsykim to merge.
Future-Outlier
moved this from In Progress
to can be merged
in @Future-Outlier's kuberay project
rueian
reviewed
Jan 6, 2026
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
machichima
reviewed
Jan 6, 2026
machichima
reviewed
Jan 6, 2026
machichima
reviewed
Jan 6, 2026
machichima
reviewed
Jan 6, 2026
machichima
reviewed
Jan 6, 2026
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
Hi, @400Ping do you mind solve the comments?
Future-Outlier
moved this from can be merged
to In Progress
in @Future-Outlier's kuberay project
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
Co-authored-by: Nary Yeh <[email protected]> Signed-off-by: Ping <[email protected]>
Co-authored-by: Rueian <[email protected]> Signed-off-by: Ping <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: 400Ping <[email protected]>
Signed-off-by: 400Ping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In this PR, we fail the RayJob if the RayCluster is provisioned. However, this is a breaking change since we shouldn’t include other modes like K8sJobMode or HTTPMode.
Related issue number
Closes #4176
Checks