[history server] [collector] Fix collector 4241 review comments #4325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
JiangJiaWei1103
changed the title
…1-review-comments-0-refactor
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
Signed-off-by: JiangJiaWei1103 <[email protected]>
JiangJiaWei1103
changed the title
Signed-off-by: JiangJiaWei1103 <[email protected]>
JiangJiaWei1103
commented
Jan 3, 2026
Comment on lines
+23
to
+24
| CreationTime string `json:"creationTime"` | ||
| CreationTimestamp int64 `json:"creationTimestamp"` |
Contributor
Author
There was a problem hiding this comment.
I think CreationTime is more human-friendly and can be displayed directly in the UI. In contrast, CreationTimestamp is more machine-oriented and better suited for sorting and comparisons, for example:
kuberay/historyserver/pkg/utils/types.go
Line 31 in 7b2acae
If this feels redundant, we can discuss which one to keep to improve maintainability.
Original discussion: #4241 (comment)
|
|
||
| // OSS meta file keys used by history server. | ||
| const ( | ||
| RayMetaFile_BasicInfo = "ack__basicinfo" |
Contributor
Author
There was a problem hiding this comment.
We need to clarify where these env vars will be used.
Signed-off-by: JiangJiaWei1103 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR focuses on non-functional cleanup to improve readability, consistency, and maintainability.
Changes
Related issue number
#4304.
NOTE: This PR addresses all review comments, except for the docs part.
Checks