Skip to content

feat: Sync rayjob or raycluster label to podgroup #4286 #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dushulin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Sync rayjob or raycluster label to podgroup #4286 #4340

dushulin wants to merge 3 commits into from

Conversation

@dushulin
Copy link
Contributor

@dushulin dushulin commented Jan 5, 2026 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

win5923
win5923 reviewed Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@win5923 win5923 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Could you add unit tests to test the change?

Future-Outlier
Future-Outlier reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you update the PR description?

seanlaii
seanlaii reviewed Jan 6, 2026
View reviewed changes
Copy link
Contributor

@seanlaii seanlaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@win5923 win5923 win5923 left review comments

@Future-Outlier Future-Outlier Future-Outlier left review comments

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

@andrewsykim andrewsykim Awaiting requested review from andrewsykim andrewsykim is a code owner

@rueian rueian Awaiting requested review from rueian rueian is a code owner

@MortalHappiness MortalHappiness Awaiting requested review from MortalHappiness MortalHappiness is a code owner

+1 more reviewer

@seanlaii seanlaii seanlaii left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dushulin @seanlaii @win5923 @Future-Outlier