Skip to content

Fix build with GCC 15 #56243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix build with GCC 15 #56243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ray/observability/open_telemetry_metric_recorder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#pragma once

#include <cstdint>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly fixes the build with GCC 15. However, since the placement of <cstdint> is a workaround and intentionally violates the project's standard include order (as you noted regarding format.sh), it's crucial to add a comment. This will prevent other developers from 'fixing' the order in the future and reintroducing the build failure. The comment should explain why this specific order is necessary and refer to the relevant issues.

Suggested change
#include <cstdint>
// Included before opentelemetry headers to fix build with GCC 15. This is a
// workaround for a missing include in opentelemetry-cpp, see
// https://github.com/open-telemetry/opentelemetry-cpp/pull/3240.
// See Ray issue #56242. Do not re-order.
#include <cstdint>

#include <opentelemetry/metrics/meter.h>
#include <opentelemetry/metrics/observer_result.h>
#include <opentelemetry/metrics/sync_instruments.h>
Expand Down