[core] Support token based auth in ray dashboard UI #58368
+826
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 3, 2025 08:01
Signed-off-by: sampan <[email protected]>
Signed-off-by: sampan <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces token-based authentication for the Ray Dashboard UI, which is a significant security improvement. The implementation is well-structured, separating concerns into different modules for authentication logic, cookie management, and UI components. The use of Axios interceptors to handle token injection and authentication errors is a clean approach. The backend changes in http_server_head.py correctly define public endpoints to allow the UI to load and prompt for a token. The addition of comprehensive tests for the new components and logic is also commendable. I have a few suggestions to improve maintainability and clean up some code.
python/ray/dashboard/client/src/authentication/TokenAuthenticationDialog.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
November 3, 2025 08:35
Signed-off-by: sampan <[email protected]>
Signed-off-by: sampan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
when token auth is enabled, the dashboard prompts the user to enter the valid auth token and caches it (as a browser cookie). when token based auth is disabled, existing behaviour is retained.
all dashboard ui based rpc's to to the ray cluster set the authorization header in their requests
Screenshots
token popup
on entering an invalid token
