Skip to content

Conversation

@elliot-barn
Copy link
Contributor

@elliot-barn elliot-barn commented Nov 3, 2025

upgrading rllib release tests to run on python 3.10

Release link: https://buildkite.com/ray-project/release/builds/66495#_
All failing tests are disabled

Signed-off-by: elliot-barn <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades several RLlib release tests to use Python 3.10 by adding python: "3.10" to their configurations in release/release_tests.yaml. The changes are consistent and correctly applied to all tests within the RLlib tests group, which aligns with the PR's stated goal. The changes appear correct and I have no specific comments on the diffs. As a potential follow-up, you might consider also updating the long_running_impala test, which is owned by team: rllib, to Python 3.10 for consistency across all RLlib-related tests.

@elliot-barn elliot-barn changed the title [release] RlLib py310 upgrades [release] RlLib py310 release test upgrades Nov 3, 2025
@ray-gardener ray-gardener bot added rllib RLlib related issues devprod release-test release test labels Nov 4, 2025
@elliot-barn elliot-barn requested a review from aslonnie November 4, 2025 02:39
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 4, 2025
@aslonnie aslonnie merged commit 60de6e8 into master Nov 6, 2025
5 of 6 checks passed
@aslonnie aslonnie deleted the elliot-barn/rllib-release-tests-py310 branch November 6, 2025 19:27
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
upgrading rllib release tests to run on python 3.10

Release link: https://buildkite.com/ray-project/release/builds/66495#_
All failing tests are disabled

Signed-off-by: elliot-barn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devprod go add ONLY when ready to merge, run all tests release-test release test rllib RLlib related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants