[Data] Expose datasources via package exports#60645
Open
400Ping wants to merge 6 commits intoray-project:masterfrom
Open
[Data] Expose datasources via package exports#60645400Ping wants to merge 6 commits intoray-project:masterfrom
400Ping wants to merge 6 commits intoray-project:masterfrom
Conversation
Signed-off-by: 400Ping <jiekaichang@apache.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a nice refactoring that centralizes datasource imports, making the codebase cleaner and easier to maintain. The changes are consistent with the stated goal of creating a single entry point for datasources. I've identified one minor omission regarding the export of JSON_FILE_EXTENSIONS, which I've detailed in the review comments. Other than that, the changes look solid.
ray-gardener
bot
added
data
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: 400Ping <jiekaichang@apache.org>
Contributor
Author
|
@bveeramani PTAL |
Contributor
Author
Signed-off-by: Jie-Kai Chang <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goal:
Make
ray.data._internal.datasourcea package entry point with short imports and alphabetized__all__.Changes:
Add/complete
__all__in datasource/datasink modules and re-export via__init__.py.Update imports to
from ray.data._internal.datasource import ....Keep private helpers module-scoped to avoid cycles and accidental exposure.
Related issues
Related to #60204
Additional information