[core][test] retry the long_running_many_jobs.py test on temporary errors#60827
Draft
rueian wants to merge 6 commits intoray-project:masterfrom
Draft
[core][test] retry the long_running_many_jobs.py test on temporary errors#60827rueian wants to merge 6 commits intoray-project:masterfrom
rueian wants to merge 6 commits intoray-project:masterfrom
Conversation
…rors Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
rueian
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds retry logic to the long_running_many_jobs.py test to handle temporary runtime errors when checking job status. The change correctly addresses potential flakiness in the test by catching RuntimeError and retrying. I have one suggestion to refactor the loop body to improve code clarity and maintainability.
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
…heme Signed-off-by: Rueian Huang <rueiancsie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rors
Description
Related issues
Additional information