[core] Fix actor task queue blocked after cancelling head task#60850
Open
Yicheng-Lu-llll wants to merge 2 commits intoray-project:masterfrom
Open
[core] Fix actor task queue blocked after cancelling head task#60850Yicheng-Lu-llll wants to merge 2 commits intoray-project:masterfrom
Yicheng-Lu-llll wants to merge 2 commits intoray-project:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly fixes a bug where the actor task queue could remain blocked if the head task was cancelled while still queued (e.g., waiting for dependency resolution). The changes ensure that the pending calls counter is properly decremented and that subsequent tasks in the queue are triggered for submission. The added test case in python/ray/tests/test_actor_cancel.py effectively reproduces and validates the fix.
Signed-off-by: yicheng <yicheng@anyscale.com>
38578cc to
6398c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the head actor task in the queue is waiting for dependency resolution and gets cancelled via
ray.cancel(), subsequent tasks in the queue may get stuck forever.pending_requests_ray.cancel(ref_a)is called, which removes A from the queueCancelTaskdoesn't callSendPendingTasks(), so B remains stuck in the queue foreverSendPendingTasksagainFix:
In
CancelTask, after removing the cancelled task from the queue, callSendPendingTasks()to unblock any subsequent ready tasks.Test
before:
after: