[Core] Fix test_failed_task_runtime_env_setup failure on windows#60852
Open
sampan-s-nayak wants to merge 3 commits intomasterfrom
Open
[Core] Fix test_failed_task_runtime_env_setup failure on windows#60852sampan-s-nayak wants to merge 3 commits intomasterfrom
sampan-s-nayak wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: sampan <sampan@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a test failure on Windows for test_failed_task_runtime_env_setup. The fix involves explicitly adding "channels": ["defaults"] to the conda runtime environment configuration within the test. This ensures that conda has a defined channel to search for packages, making the test's failure condition—a non-existent package—more reliable and platform-independent. The change is correct and improves the robustness of the test suite. I approve of this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix test_failed_task_runtime_env_setup failure on windows by setting conda channel