-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Updated Bartender package.json description to point out that Bartender 6 is not and cannot be supported #24154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days. |
Greptile SummaryUpdated the extension description to inform users that Bartender 6 is not supported due to broken AppleScript functionality in that version, while Bartender 5 remains supported.
Confidence Score: 5/5
Important Files Changed
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
pernielsentikaer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we check which version of macOS the user is on and show a warning about it?
I converted this PR into a draft until it's ready for the review, please press the button Ready for review when it's ready and we'll have a look 😊
Hoping to get your take on the best way to handle this. Even if Bartender 6 fixes their AppleScript issues, testing across both versions 5 and 6 is difficult because of the OS support gap. Can we limit this extension to Bartender 5, or does Raycast generally discourage version-specific extensions? In a Bartender 5 only world, we could check the version quite easily but I would be unable to fully test that it functions. Thanks! |
|
We can call it Bartender 5 in the title, and if 6 will be better supported then we can add that? |
Description
Bartender 6 has broken AppleScript support. Developer made one comment on Reddit a few months ago acknowledging the issue. This PR just adds one sentence to the description explaining that Bartender 6 is not supported.
See #24141, #21856, #22268, #21797.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool