-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add micplus extension #24508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add micplus extension #24508
Conversation
|
Congratulations on your new Raycast extension! 🚀 Due to our current reduced availability, the initial review may take up to 10-15 business days. Once the PR is approved and merged, the extension will be available on our Store. |
Greptile SummaryAdds a Windows-only extension for controlling microphone state using NirCmd. The extension provides four commands (toggle, mute, unmute, and status check) and allows users to configure a custom NirCmd path or use the system PATH. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
12 files reviewed, 1 comment
| interface Preferences { | ||
| nircmdPath?: string; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Remove manual Preferences interface definition. Raycast auto-generates these types in raycast-env.d.ts when the extension runs.
| interface Preferences { | |
| nircmdPath?: string; | |
| } |
Context Used: Rule from dashboard - What: Don't manually define Preferences for getPreferenceValues() or commends Argument interfa... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
0xdhrv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🔥
We already have an extension in the Store that provide Mic functionality. Could we consider enhancing the existing extension below instead of creating another one?
I see you have it added for the Windows platform, but I think you can enhance the existing extension for Windows.
If there are unique features or workflows you’re aiming to add, we’d love to hear them and see if they can be integrated into this to avoid duplication and improve discoverability.
This would help avoid duplication and keep related functionality consolidated in one place.
As mentioned in our extension guidelines here ↗
Thanks for the review! The main reason I submitted this separately is that native microphone control on Windows is quite restrictive compared to macOS. This extension relies specifically on nircmd to function reliably, and merging it with a macOS-focused extension would complicate the codebase due to these distinct dependencies. If maintaining this as a separate, Windows-specific extension doesn't align with the Store's goals, I am completely fine with closing this PR and keeping it on my personal GitHub for my own use. However, if you do decide to include it, I am willing to investigate a native solution in the future to reduce dependencies, though I cannot guarantee a stable native implementation due to the OS limitations. |
I see what you mean. With this change, you can add Windows support to the existing extension so users won't need two different ones. The same extension will support Windows once this PR, which is under review, is merged |
Hi, i did what you want here: #24640. Can you please check it? |
Description
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder