Skip to content

[wrap-text] Fix clipboard race condition after paste #26760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycastbot merged 2 commits into from
Mar 30, 2026
+5 −1
Merged

[wrap-text] Fix clipboard race condition after paste #26760

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
442ccff
[wrap-text] Fix clipboard race condition after paste
tmchow Mar 30, 2026
86d32ec
[wrap-text] Add changelog entry for clipboard race fix
tmchow Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/wrap-text/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export async function wrapSelectedText(left: string, right: string = left) {
const previousClipboard = await Clipboard.read();

await Clipboard.paste(wrapped);
await new Promise((resolve) => setTimeout(resolve, 200));
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Hardcoded delay may be brittle on slow systems

The 200ms delay is a reasonable heuristic that works for most apps under normal conditions. However, on heavily loaded machines or with applications that have slower paste handling, the race condition could still occur. There's no deterministic way to know when the target app has processed the Cmd+V, so a time-based delay is a practical approach here — but it may be worth documenting this limitation in a comment so future maintainers understand why this number was chosen.

Suggested change
await new Promise((resolve) => setTimeout(resolve, 200));
await new Promise((resolve) => setTimeout(resolve, 200)); // Give the target app time to process Cmd+V before clipboard is restored
Prompt To Fix With AI 
This is a comment left during a code review.
Path: extensions/wrap-text/src/utils.ts
Line: 18

Comment:
**Hardcoded delay may be brittle on slow systems**

The 200ms delay is a reasonable heuristic that works for most apps under normal conditions. However, on heavily loaded machines or with applications that have slower paste handling, the race condition could still occur. There's no deterministic way to know when the target app has processed the `Cmd+V`, so a time-based delay is a practical approach here — but it may be worth documenting this limitation in a comment so future maintainers understand why this number was chosen.

```suggestion
    await new Promise((resolve) => setTimeout(resolve, 200)); // Give the target app time to process Cmd+V before clipboard is restored
```

How can I resolve this? If you propose a fix, please make it concise.


// Restore the previous clipboard content.
if (previousClipboard.text !== undefined) {
Expand Down
Loading