Skip to content

Conversation

@JohnnyCena123
Copy link
Contributor

No description provided.

@raysan5 raysan5 changed the title use FLAG_* macros where possible [rcore] Use FLAG_* macros where possible Sep 4, 2025
@raysan5
Copy link
Owner

raysan5 commented Oct 1, 2025

@JohnnyCena123 I've been thinking about this update and I'm merging it but I'm concerned about the macro FLAG_CHECK(), I think it's not clear enough and when implemented it could lead to confusions. I think it could be replaced by FLAG_IS_SET() macro, checking directly if the requested flag is set (or not).

So, code needs to be updated from:

if (FLAG_CHECK(CORE.Window.flags, FLAG_WINDOW_MINIMIZED) > 0) { }

to

if (FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }

or depending the case

if (!FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }

Please, could you review it?

@raysan5
Copy link
Owner

raysan5 commented Oct 7, 2025

@JohnnyCena123 Did you see my previous message? I can implement it if you can't.

@JohnnyCena123
Copy link
Contributor Author

@JohnnyCena123 Did you saw my previous message? I can implement it if you can't.

sorry, I must've missed it. I will do that tomorrow if I remember

@JohnnyCena123
Copy link
Contributor Author

@raysan5 i remembered!

@raysan5
Copy link
Owner

raysan5 commented Oct 16, 2025

@JohnnyCena123 Added some code reviews. Did you test the changes? There is a windows_config_flags example to test some of them...

@raysan5
Copy link
Owner

raysan5 commented Oct 25, 2025

@JohnnyCena123 Added some point to review, did you check them?

Copy link
Contributor

@orcmid orcmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are excessive and impose extensive challenges on reviewers. Also, it is not clear how any of these are related to the subject of the #5169.

Break it into smaller changes all with specific stated purposes.

@raysan5 raysan5 merged commit 5fbf67a into raysan5:master Nov 2, 2025
16 checks passed
@raysan5
Copy link
Owner

raysan5 commented Nov 2, 2025

@orcmid Agree, this is a big change that could potentially break things, this time I'm merging it and reviewing myself carefully but definitely the last time I'm accepting this kinf of PR. Hopefully everything will be ok and hopefully contributor tested everu¡ything works as expected...

@JohnnyCena123 Thanks for the reeview, I'm merging it.

raysan5 added a commit that referenced this pull request Nov 2, 2025
@JeffM2501
Copy link
Contributor

This PR breaks IsWindowFocused in GLFW.
The inital focus state is correct, but after that the state will be inverted.
This video shows the problem.
I did A/B testing and found that this PR is the culprit.

This PR makes rlImGui non functional in head. It should be fixed or reverted.

Recording.2025-11-03.113813.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants