-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[rcore] Use FLAG_* macros where possible
#5169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3255f2b to
4fbf247
Compare
4fbf247 to
70a06f9
Compare
FLAG_* macros where possible
|
@JohnnyCena123 I've been thinking about this update and I'm merging it but I'm concerned about the macro So, code needs to be updated from: if (FLAG_CHECK(CORE.Window.flags, FLAG_WINDOW_MINIMIZED) > 0) { }to if (FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }or depending the case if (!FLAG_IS_SET(CORE.Window.flags, FLAG_WINDOW_MINIMIZED)) { }Please, could you review it? |
|
@JohnnyCena123 Did you see my previous message? I can implement it if you can't. |
sorry, I must've missed it. I will do that tomorrow if I remember |
|
@raysan5 i remembered! |
38410b5 to
a49f79b
Compare
|
@JohnnyCena123 Added some code reviews. Did you test the changes? There is a windows_config_flags example to test some of them... |
|
@JohnnyCena123 Added some point to review, did you check them? |
orcmid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are excessive and impose extensive challenges on reviewers. Also, it is not clear how any of these are related to the subject of the #5169.
Break it into smaller changes all with specific stated purposes.
|
@orcmid Agree, this is a big change that could potentially break things, this time I'm merging it and reviewing myself carefully but definitely the last time I'm accepting this kinf of PR. Hopefully everything will be ok and hopefully contributor tested everu¡ything works as expected... @JohnnyCena123 Thanks for the reeview, I'm merging it. |
|
This PR breaks IsWindowFocused in GLFW. This PR makes rlImGui non functional in head. It should be fixed or reverted. Recording.2025-11-03.113813.mp4 |
No description provided.