[rlsw] Fix clipping boundary overflow #5342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the buffer overrun issue reported here: #5326 (comment)
After investigating the problem, the most reasonable approach seems to be using exclusive tests for the X/Y planes during clipping while keeping inclusive tests for Z.
The current clipping implementation is based on multiple rewrites of the approach originally described in this blog:
https://fabiensanglard.net/polygon_codec/
Our original implementation followed the same conditional logic as in the blog post, but this behavior might also be related to the projection [NDC -> screen] convention we follow (and which didn't seem to be a problem anyway in the context of the blog post), so clipping with exclusive X/Y borders seems more consistent in our case, while keeping Z inclusive avoids losing fragments.
For reference, here are the original papers that describes the logic: