Skip to content

[rcore] Fix high DPI render size and window deformation #5356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −9
Open

[rcore] Fix high DPI render size and window deformation #5356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/platforms/rcore_desktop_glfw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1808,30 +1808,35 @@ static void WindowSizeCallback(GLFWwindow *window, int width, int height)
// WARNING: On window minimization, callback is called,
// but we don't want to change internal screen values, it breaks things
if ((width == 0) || (height == 0)) return;
int fbWidth, fbHeight;
glfwGetFramebufferSize(window, &fbWidth, &fbHeight);

// Reset viewport and projection matrix for new size
SetupViewport(width, height);
SetupViewport(fbWidth, fbHeight);

CORE.Window.currentFbo.width = width;
CORE.Window.currentFbo.height = height;
CORE.Window.currentFbo.width = fbWidth;
CORE.Window.currentFbo.height = fbHeight;
CORE.Window.resizedLastFrame = true;

if (IsWindowFullscreen()) return;
int logicalWidth = width;
int logicalHeight = height;

// if we are doing automatic DPI scaling, then the "screen" size is divided by the window scale
if (IsWindowState(FLAG_WINDOW_HIGHDPI))
{
width = (int)(width/GetWindowScaleDPI().x);
height = (int)(height/GetWindowScaleDPI().y);
Vector2 dpiScale = GetWindowScaleDPI();
logicalWidth = (int)(fbWidth / dpiScale.x);
logicalHeight = (int)(fbHeight / dpiScale.y);
}

// Set render size
CORE.Window.render.width = width;
CORE.Window.render.height = height;
CORE.Window.render.width = fbWidth;
CORE.Window.render.height = fbHeight;

// Set current screen size
CORE.Window.screen.width = width;
CORE.Window.screen.height = height;
CORE.Window.screen.width = logicalWidth;
CORE.Window.screen.height = logicalHeight;

// WARNING: If using a render texture, it is not scaled to new size
}
Expand Down