fix: change delete confirm input field from name to title #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 19559459153Details
💛 - Coveralls |
rohilsurana
reviewed
Nov 20, 2025
| async function onSubmit(data: any) { | ||
| if (!organization?.id) return; | ||
| if (data.name !== organization.name) | ||
| if (data.name !== organization.title) |
Member
There was a problem hiding this comment.
lets change the form field naming as well to title ?
Member
|
PR title should be opposite, name to title ? |
rohilsurana
reviewed
Nov 20, 2025
| if (!organization?.id || !projectId) return; | ||
| if (data.name !== project?.name) | ||
| return setError('name', { message: 'project name is not same' }); | ||
| if (data.name !== project?.title) |
rohilsurana
reviewed
Nov 20, 2025
|
|
||
| if (data.name !== team?.name) | ||
| return setError('name', { message: 'team name is not same' }); | ||
| if (data.name !== team?.title) |
paanSinghCoder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Changes
Organization Deletion (general/delete.tsx)
Teams Deletion (teams/delete.tsx)
Projects Deletion (project/delete.tsx)
Domain Deletion (domain/delete.tsx)
Technical Details
Test Plan