refactor(billing): simplify checkout RPCs by inferring billing_id #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PROTON_COMMIT to 60d2868d31c9f3696e80eed12e8dc9d38c4a027f This picks up the proto changes that mark billing_id as deprecated in: - CreateCheckoutRequest - ListCheckoutsRequest - GetCheckoutRequest - DelegatedCheckoutRequest (admin) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 19561878789Details
💛 - Coveralls |
- Update CreateCheckout, ListCheckouts, DelegatedCheckout handlers to infer billing_id from org_id - Update GetCheckout to not require org_id (infers from checkout_id) - Add GetOrgIDFromCheckoutID helper function - Remove ensureBillingAccountBelongToOrg checks from authorization interceptors - Update GetCheckout interceptor to infer org_id from checkout_id for authorization - Regenerate protos with deprecated fields Security improvement: Clients can no longer pass arbitrary billing_id values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Function is no longer used after refactoring GetCheckout authorization to infer org_id from checkout_id. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor checkout RPCs to automatically infer
billing_idfromorg_id, removing redundant parameters and improving API security.Changes
Proto (Proton):
billing_idas deprecated in CreateCheckout, ListCheckouts, GetCheckout, DelegatedCheckoutorg_idas deprecated in GetCheckout (can fetch by checkout ID alone)Backend (Frontier):
billing_idfromorg_idorg_idrequirement, infer fromcheckout_idGetOrgIDFromCheckoutID()helper functionensureBillingAccountBelongToOrgchecksorg_idfromcheckout_idBackward Compatibility
✅ No breaking changes - All existing clients continue to work:
Security Improvement
Clients can no longer pass arbitrary
billing_idvalues, preventing potential unauthorized access to other organizations' billing data.Related