feat: Add audit record APIs and deprecate existing audit log APIs #422
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new audit record APIs and deprecates the existing audit log APIs in Frontier. The changes establish a more structured audit system with dedicated data models for audit records while maintaining backward compatibility through deprecation warnings.
- Adds new
AuditRecordmodel with structured actor, resource, and target components - Introduces user-facing
CreateAuditRecordAPI and admin-onlyListAuditRecordsAPI - Deprecates existing organization-scoped audit log APIs with migration guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| raystack/frontier/v1beta1/models.proto | Defines new audit record data models with actor, resource, target, and main record structures |
| raystack/frontier/v1beta1/frontier.proto | Deprecates existing audit log APIs and adds new CreateAuditRecord endpoint |
| raystack/frontier/v1beta1/admin.proto | Adds admin-only ListAuditRecords API for audit record retrieval |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| message AuditRecord { | ||
| string id = 1; | ||
|
|
There was a problem hiding this comment.
[nitpick] Remove the extra blank line after the id field declaration to maintain consistent spacing throughout the message definition.
Copilot uses AI. Check for mistakes.
| @@ -788,6 +788,9 @@ service AdminService { | |||
| // Revoke a specific session for a specific user (admin only). | |||
| rpc RevokeUserSession(RevokeUserSessionRequest) returns (RevokeUserSessionResponse) {} | |||
|
|
|||
| // Audit Records (Admin Only) | |||
| rpc ListAuditRecords(ListAuditRecordsRequest) returns (ListAuditRecordsResponse) {} | |||
There was a problem hiding this comment.
Consider adding the GetAuditRecord RPC mentioned in the deprecation messages. The deprecated GetOrganizationAuditLog references 'admin GetAuditRecord API' but this endpoint doesn't exist in the admin service.
Copilot uses AI. Check for mistakes.
No description provided.