fix: prevent crash when flash sale expiry date is null or empty#25
Merged
razaghimahdi merged 2 commits intorazaghimahdi:masterfrom Apr 23, 2025
Merged
fix: prevent crash when flash sale expiry date is null or empty#25razaghimahdi merged 2 commits intorazaghimahdi:masterfrom
razaghimahdi merged 2 commits intorazaghimahdi:masterfrom
Conversation
- Added safe parsing for `expiredAt` using DateTimeConverter with null fallback - Avoided showing TimerBox if `time` is null - Improved app stability on Home screen when flashSale is missing expiry date
razaghimahdi
requested changes
Apr 22, 2025
shared/src/commonMain/kotlin/presentation/ui/main/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/presentation/ui/main/home/view_model/HomeState.kt
Show resolved
Hide resolved
…hen invalid - Added extension function `String?.toLocalDateTimeOrNull()` to safely parse nullable or invalid date strings. - Used `AnimatedVisibility` to show/hide `TimerBox` only when `expiredAt` is valid. - Ensured `HomeState` remains non-nullable by providing fallback time value. - Prevented crashes when flashSale has null or malformed expiredAt values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expiredAtusing DateTimeConverter with null fallbacktimeis null