Open
Conversation
- Error methods of Error structs previously did not
check if err is nil, this caused nil pointer dereference error
- doRequestResponse function previously did not decode
Error Message
Author
|
@venkatvghub please approve, I want to avoid vendoring razorpay-go package. |
Author
|
@neera11 please approve, I want to avoid vendoring razorpay-go package. |
|
Bump! |
|
hi can we fix this asap or get a review, this is causing issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check if err is nil, this caused nil pointer dereference error
Error Message
I was getting nil pointer dereference error when trying to create Transfer of amount greater than current razorpay account balance.
This issue fixes this too.