Fix: Include obfuscated API keys in distribution zip#697
Merged
Conversation
vladjerca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for action-kodi-addon-submitter
This PR fixes an issue where the obfuscated Trakt API keys were missing from the
distribution zip.
The
xbmc/action-kodi-addon-submitteraction usesgit archive HEADunder thehood to generate the addon's zip file. Because
git archiveonly packages filesthat are committed to the repository, it was completely ignoring the uncommitted
changes made by our
scripts/inject_keys.pystep during the build.Changes
.github/workflows/submit.ymlto run a local
git commit -am "Inject obfuscated keys for build [skip ci]"immediately after running the injection script.
This ensures the modified
traktapi.pywith the obfuscated keys is included inthe
HEADarchive and successfully packaged into the release ZIP. This commitonly exists on the GitHub Actions runner and is never pushed back to the
repository.