Fix installing OpenSSL on non-Linux or with clang#2496
Merged
Conversation
The recent rpath argument addition broke compilation of OpenSSL with clang since
it seems expect this syntax (comma instead of "="):
-Wl,-rpath,<path>
Also, it doesn't seem that the rpath argument is necessary for any platform other
than "Linux"; that is, we should skip passing it on BSD and macOS.
jeremy
reviewed
Jan 14, 2025
| if [ "$CC" = "clang" ] || "${CC:-cc}" --version 2>&1 | grep -wq clang; then | ||
| package_option openssl configure -Wl,-rpath,"$OPENSSL_PREFIX_PATH/lib" | ||
| else | ||
| package_option openssl configure -Wl,-rpath="$OPENSSL_PREFIX_PATH/lib" |
Member
There was a problem hiding this comment.
Can use the comma syntax -Wl,-rpath,"$OPENSSL_PREFIX_PATH/lib" for GCC as well (the commas are split into separate args to pass to the linker, giving ld -rpath … instead of ld -rpath=…) so we can drop the clang check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent rpath argument addition broke compilation of OpenSSL with clang since it seems expect this syntax (comma instead of "="):
Also, it doesn't seem that the rpath argument is necessary for any platform other than "Linux"; that is, we should skip passing it on BSD and macOS.
Thanks @jeremy #2493 (review)