Fix using system openssl v1.x via pkg-config #2568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System openssl version reported by `pkg-config --modversion openssl` might end with a letter, e.g. "1.0.2k", due to OpenSSL versioning policy prior to OpenSSL v3: https://www.openssl-library.org/policies/general/versioning-policy/#history The letter would trip up the normalize_semver function due to it only handling numbers. This change switches to semver parsing via awk instead of doing it clumsily in bash. This also changes the multiplication factor of major version numbers, from 100000 to 10000, and adjusts static version comparisons accodingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System openssl version reported by
pkg-config --modversion opensslmight end with a letter, e.g. "1.0.2k", due to OpenSSL versioning policy prior to OpenSSL v3: https://www.openssl-library.org/policies/general/versioning-policy/#historyThe letter would trip up the normalize_semver function due to it only handling numbers.
This change switches to semver parsing via awk instead of doing it clumsily in bash. This also changes the multiplication factor of major version numbers, from 100000 to 10000, and adjusts static version comparisons accodingly.
Fixes #2567
Followup to #2547