Refactor budget enforcement to use exception-based control flow#19
Merged
Refactor budget enforcement to use exception-based control flow#19
Conversation
- Update test budgets to account for file path length being debited - Fix FileWindow validation to require line_count >= 1 (not >= 0) - Adjust budget calculations in tests to include both path and content costs - All 145 tests now pass with proper budget enforcement
ccce1a7 to
cb64a10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BudgetExceededexception-based control flowOutputBudget.debit()method for atomic operationsStreamingRegexSearcher- budget now handled atGrepperlevelGlobberto debit budget by path length instead of count for more accurate resource trackingBenefits
BudgetExceededexceptionsChanges
StreamingFileReader,Globber, andGrepperto use exception-based budget handlingStreamingRegexSearcher(budget now handled upstream)Test plan