Fix Glancer to return correct FileWindow reflecting actual content read#20
Merged
Fix Glancer to return correct FileWindow reflecting actual content read#20
Conversation
The Glancer.glance() method was returning the requested FileWindow instead of the actual window that was read from the file. For example, requesting 100 lines from an empty file would return window with line_count=100 instead of line_count=0. Changes: - Add actual_window field to FileReadResult to track what was actually read - Update StreamingFileReader to return actual window information - Modify Glancer.glance() to use actual_window instead of requested window - Allow FileWindow.line_count=0 for reporting empty reads - Add comprehensive tests covering various edge cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
actual_windowfield toFileReadResultto track what was actually readStreamingFileReader.read_window()to return actual window informationGlancer.glance()to useactual_windowinstead of requested windowFileWindowvalidation to allowline_count=0for reporting empty readstest_glancer_window_behavior.py) with 5 test cases covering edge casesTest Plan
Breaking Changes
FileReadResultnow requires anactual_windowfieldFileWindow.line_countvalidation changed fromge=1toge=0These are internal API changes that shouldn't affect most users of the public API.