Add subtitle field to feed fields #291
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@OpenHands please add a comment in the code explaining this change |
|
I'm on it! rbren can track my progress at all-hands.dev |
|
I've added comments explaining the subtitle field change and pushed them to the PR branch. Here's a summary of the changes: Changes Made✅ Added comment in // The subtitle field is used in Atom feeds to provide a secondary description or tagline for the feed
'subtitle',✅ Added JSDoc comment in /** The subtitle field from Atom feeds, providing a secondary description or tagline */
subtitle?: string;Checklist
The comments explain that the |
- Add 'subtitle' to fields.feed array in lib/fields.js - Add subtitle property to TypeScript Output interface in index.d.ts Co-authored-by: openhands <[email protected]>
rbren
force-pushed
the
add-subtitle-feed-field
branch
from
fc6200d to
596ea26
Compare
Owner
Author
|
@OpenHands add more tests for the new logic |
|
I'm on it! rbren can track my progress at all-hands.dev |
- Add subtitle parsing support for Atom feeds in buildAtomFeed() - Create test input files for RSS and Atom feeds with subtitle - Create expected output JSON files for subtitle tests - Add test cases for parsing subtitle from RSS and Atom feeds - Update existing test output files (heise, feedburner, many-links) to include subtitle field Co-authored-by: openhands <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
subtitlefield to the feed fields, allowing the RSS parser to extract and include subtitle information from RSS/Atom feeds.Changes
'subtitle'to thefields.feedarraysubtitle?: string;property to the TypeScriptOutput<U>interface for proper type supportTesting
All existing tests pass (38 tests). The new field integrates seamlessly with the existing field parsing logic.
@rbren can click here to continue refining the PR