Version 4.5.1

[rckim77]

• updates Google SDK versions to 10.10.0
• adds AGENTS.md and skill folders
• adds PR GHA workflow to run unit tests
• adds unit tests for new CityDetailViewStateTests

[Copilot]

Pull request overview

This PR updates the project’s Google Maps/Places SwiftPM dependency versions and adds repository guidance for coding agents via a new AGENTS.md plus a set of .agents/skills/* reference documents.

Changes:

• Bump ios-maps-sdk and ios-places-sdk SwiftPM dependencies from 10.4.0 to 10.10.0 (project + resolved lockfile).
• Add AGENTS.md with repo setup, validation, and workflow expectations.
• Introduce a set of agent “skills” references under .agents/skills/ (SwiftUI patterns, Swift concurrency, App Store changelog, etc.).

Reviewed changes

Copilot reviewed 66 out of 66 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
Daydream.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved	Updates resolved SwiftPM pins for Google Maps/Places packages to 10.10.0.
Daydream.xcodeproj/project.pbxproj	Updates Swift package exactVersion requirements for Google Maps/Places to 10.10.0.
AGENTS.md	Adds agent-facing repo setup/build/validation notes and workflow expectations.
.agents/skills/swiftui-ui-patterns/SKILL.md	Adds a SwiftUI UI patterns skill index and workflow guidance.
.agents/skills/swiftui-ui-patterns/references/app-wiring.md	Adds reference guidance for wiring app shells and dependency graphs.
.agents/skills/swiftui-ui-patterns/references/components-index.md	Adds an index of available SwiftUI UI pattern references.
.agents/skills/swiftui-ui-patterns/references/controls.md	Adds guidance/examples for native SwiftUI controls usage.
.agents/skills/swiftui-ui-patterns/references/deeplinks.md	Adds guidance/examples for deep link routing patterns.
.agents/skills/swiftui-ui-patterns/references/focus.md	Adds guidance/examples for focus management and field chaining.
.agents/skills/swiftui-ui-patterns/references/form.md	Adds guidance/examples for Form-based layouts and validation.
.agents/skills/swiftui-ui-patterns/references/grids.md	Adds guidance/examples for LazyVGrid patterns.
.agents/skills/swiftui-ui-patterns/references/haptics.md	Adds guidance/examples for haptics usage and centralization.
.agents/skills/swiftui-ui-patterns/references/input-toolbar.md	Adds guidance/examples for bottom-anchored input toolbars.
.agents/skills/swiftui-ui-patterns/references/list.md	Adds guidance/examples for List/Section patterns and styling.
.agents/skills/swiftui-ui-patterns/references/loading-placeholders.md	Adds guidance/examples for loading placeholders and empty states.
.agents/skills/swiftui-ui-patterns/references/lightweight-clients.md	Adds guidance/examples for closure-based lightweight clients and stores.
.agents/skills/swiftui-ui-patterns/references/macos-settings.md	Adds guidance/examples for macOS Settings scenes.
.agents/skills/swiftui-ui-patterns/references/matched-transitions.md	Adds guidance/examples for matched transitions / geometry effects.
.agents/skills/swiftui-ui-patterns/references/media.md	Adds guidance/examples for media loading and viewer presentation.
.agents/skills/swiftui-ui-patterns/references/menu-bar.md	Adds guidance/examples for SwiftUI menu bar commands.
.agents/skills/swiftui-ui-patterns/references/navigationstack.md	Adds guidance/examples for NavigationStack routing patterns.
.agents/skills/swiftui-ui-patterns/references/overlay.md	Adds guidance/examples for overlay/toast patterns.
.agents/skills/swiftui-ui-patterns/references/scrollview.md	Adds guidance/examples for ScrollView + Lazy stacks usage.
.agents/skills/swiftui-ui-patterns/references/searchable.md	Adds guidance/examples for searchable with debounced tasks.
.agents/skills/swiftui-ui-patterns/references/sheets.md	Adds guidance/examples for enum-driven sheet routing.
.agents/skills/swiftui-ui-patterns/references/split-views.md	Adds guidance/examples for split view / columns patterns.
.agents/skills/swiftui-ui-patterns/references/tabview.md	Adds guidance/examples for scalable TabView architectures.
.agents/skills/swiftui-ui-patterns/references/theming.md	Adds guidance/examples for theming + dynamic type patterns.
.agents/skills/swiftui-ui-patterns/references/title-menus.md	Adds guidance/examples for title menus in toolbars.
.agents/skills/swiftui-ui-patterns/references/top-bar.md	Adds guidance/examples for top bar overlays with iOS-availability fallback.
.agents/skills/swiftui-expert-skill/SKILL.md	Adds a SwiftUI expert skill checklist and best-practices guidance.
.agents/skills/swiftui-expert-skill/references/animation-advanced.md	Adds advanced animation guidance (transactions, phase/keyframe animators).
.agents/skills/swiftui-expert-skill/references/animation-basics.md	Adds core animation guidance (implicit/explicit, placement, performance).
.agents/skills/swiftui-expert-skill/references/animation-transitions.md	Adds transitions and Animatable protocol guidance.
.agents/skills/swiftui-expert-skill/references/image-optimization.md	Adds AsyncImage and optional downsampling optimization guidance.
.agents/skills/swiftui-expert-skill/references/layout-best-practices.md	Adds layout best practices and testability guidance.
.agents/skills/swiftui-expert-skill/references/liquid-glass.md	Adds iOS 26+ Liquid Glass API guidance and fallback patterns.
.agents/skills/swiftui-expert-skill/references/list-patterns.md	Adds ForEach identity/list pitfalls guidance.
.agents/skills/swiftui-expert-skill/references/modern-apis.md	Adds guidance on modern SwiftUI API usage vs deprecated patterns.
.agents/skills/swiftui-expert-skill/references/performance-patterns.md	Adds SwiftUI performance guidance and common anti-patterns.
.agents/skills/swiftui-expert-skill/references/scroll-patterns.md	Adds ScrollView patterns, indicators, paging, and performance guidance.
.agents/skills/swiftui-expert-skill/references/sheet-navigation-patterns.md	Adds patterns for sheet presentation and navigation approaches.
.agents/skills/swiftui-expert-skill/references/text-formatting.md	Adds guidance for modern formatting with Text(..., format:) and localization.
.agents/skills/swiftui-expert-skill/references/view-structure.md	Adds guidance for view identity, extraction, and container composition patterns.
.agents/skills/swift-concurrency/SKILL.md	Adds a Swift concurrency skill with workflow and triage guidance.
.agents/skills/swift-concurrency/references/_index.md	Adds an index for concurrency reference topics.
.agents/skills/swift-concurrency/references/async-await-basics.md	Adds async/await fundamentals and URLSession examples.
.agents/skills/swift-concurrency/references/glossary.md	Adds a concurrency terminology glossary.
.agents/skills/swift-concurrency/references/linting.md	Adds guidance for SwiftLint concurrency rules and suppressions.
.agents/skills/swift-concurrency/references/threading.md	Adds threading vs isolation explanation and Swift 6.x behavior notes.
.agents/skills/github/SKILL.md	Adds guidance for using gh CLI for PRs/issues/runs.
.agents/skills/apple-hig-page-controls/SKILL.md	Adds Apple HIG guidance for page controls (dot indicators).
.agents/skills/app-store-changelog/SKILL.md	Adds workflow guidance for producing App Store release notes from git history.
.agents/skills/app-store-changelog/references/release-notes-guidelines.md	Adds release notes language/filtering guidelines.
.agents/skills/app-store-changelog/scripts/collect_release_changes.sh	Adds a helper script to collect commits/files touched for release notes.

Comments suppressed due to low confidence (7)

AGENTS.md:38

• The suggested xcodebuild destination uses name=iPhone 17 Pro, which is likely not present on many developer machines and will cause xcodebuild to fail with an invalid destination/device error. Consider using a more common simulator name already referenced elsewhere in the repo (e.g., iPhone 15/16 Pro) or documenting a generic destination and instructing developers to pick an installed simulator.
  AGENTS.md:3
• PR title mentions adding a skillsVersion, but there doesn’t appear to be any skillsVersion file/key added in this change set (and the repo currently has no occurrences of skillsVersion). Either add the intended skillsVersion artifact or update the PR title/description to match the actual changes.
  .agents/skills/swiftui-ui-patterns/SKILL.md:25
• This references references/app-scaffolding-wiring.md, but the skill’s references folder contains app-wiring.md (and no app-scaffolding-wiring.md). This broken link makes the guidance hard to follow; update the filename reference or add the missing file.
  .agents/skills/swiftui-ui-patterns/references/split-views.md:53
• This markdown contains literal \n escape sequences in the middle of a sentence/bullet list, which will render incorrectly in GitHub. Replace the \n sequences with actual newlines so the list formats properly.
  .agents/skills/swiftui-expert-skill/references/view-structure.md:193
• The example uses @ViewBuilder let content: Content, which isn’t valid Swift syntax for a stored property (result builders apply to closures/computed properties). This makes the “GOOD” example misleading; use an init(@ViewBuilder content: () -> Content) that stores Content, or store a closure let content: () -> Content and call it in body.
  .agents/skills/swiftui-expert-skill/references/list-patterns.md:153
• The checklist item says “Don’t convert enumerated sequences to arrays”, but the section above correctly states you should wrap enumerated() with Array(...) to use it in ForEach. Update the checklist bullet to match the guidance (e.g., “Convert enumerated sequences to arrays” / “Don’t forget to convert…”).

## Summary Checklist

- [ ] ForEach uses stable identity (never `.indices` for dynamic content)
- [ ] Constant number of views per ForEach element
- [ ] No inline filtering in ForEach (prefilter and cache instead)
- [ ] No `AnyView` in list rows
- [ ] Don't convert enumerated sequences to arrays
- [ ] Use `.refreshable` for pull-to-refresh
- [ ] Custom list styling uses appropriate modifiers

.agents/skills/swiftui-expert-skill/SKILL.md:90

• This guidance recommends @ViewBuilder let content: Content, which isn’t valid Swift for a stored property and can mislead users of this skill. Consider updating the recommendation to the standard pattern: store let content: Content and accept it via init(@ViewBuilder content: () -> Content), or store a closure let content: () -> Content.

- Extract complex views into separate subviews for better readability and performance
- Keep views small for optimal performance
- Keep view `body` simple and pure (no side effects or complex logic)
- Use `@ViewBuilder` functions only for small, simple sections
- Prefer `@ViewBuilder let content: Content` over closure-based content properties
- Separate business logic into testable models (not about enforcing architectures)
- Action handlers should reference methods, not contain inline logic
- Use relative layout over hard-coded constants
- Views should work in any context (don't assume screen size or presentation style)

[rckim77]

@codex[agent] review this PR and figure out why unit tests in CI are failing

[Codex]

@rckim77 I've opened a new pull request, #87, to work on those changes. Once the pull request is ready, I'll request review from you.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40bf7498b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Use an available simulator runtime in CI destination

In the unit_tests workflow I inspected (.github/workflows/pr-tests.yml), the destination is pinned to OS=26.2,arch=arm64. xcodebuild test requires an exact matching simulator runtime/arch for -destination, so if the macOS-15 image doesn’t ship that exact combo the command fails before any tests execute (typically as an “unable to find a destination” failure), which presents as unit tests failing in CI even though test code never ran.

Useful? React with 👍 / 👎.