Skip to content

Add portable-atomic support for spin-based locking on no-atomic targets #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lfan-ke wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add portable-atomic support for spin-based locking on no-atomic targets #43

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccffb1b
update: Cargo.toml
Lfan-ke Jan 11, 2026
1a0458a
Update Cargo.toml
Lfan-ke Jan 11, 2026
a3dd15f
Update Cargo.toml
Lfan-ke Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ documentation = "https://docs.rs/buddy_system_allocator"
homepage = "https://github.com/rcore-os/buddy_system_allocator"
repository = "https://github.com/rcore-os/buddy_system_allocator"
keywords = ["allocator", "no_std", "heap"]
version = "0.11.0"
version = "0.11.1"
authors = [
"Jiajie Chen <c@jia.je>",
"Vinay Chandra Dommeti <github@vinay.vc>",
Expand All @@ -17,13 +17,20 @@ license = "MIT"
[features]
default = ["alloc", "use_spin"]
alloc = []
use_spin = ["spin"]
soft_atomic_spin_single_core = ["spin/portable-atomic", "portable-atomic/unsafe-assume-single-core"]
Copy link
Member

@jiegec jiegec Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we really need this: By https://doc.rust-lang.org/cargo/reference/features.html#feature-unification, you can enable spin/portable-atomic in a downstream project if necessary.

Copy link
Member

@jiegec jiegec Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real feature wanted here is to use spin without spin_mutex?

soft_atomic_spin_critical_section = ["spin/portable-atomic", "portable-atomic/critical-section"]
use_spin = ["spin/spin_mutex"]

[dependencies.spin]
version = "0.10.0"
optional = true
default-features = false
features = ["spin_mutex"]
features = []

[dependencies.portable-atomic]
version = "1.13.0"
optional = true
default-features = false

[dev-dependencies]
criterion = "0.6.0"
Expand Down
Loading