Merged
Conversation
I hotfixed to live without fully understanding the problem so users were unblocked. The problem was I tested #1369 as an audit team member who have short circuit permission to do any edits. Testing as a lead clinician revealed that it crashed confirming eligibility or any other operations on a blank registration (created on demand when first loading the register page). The test of course passes as the fix worked but adding it for posterity.
rcpch-prout
Bot
added
Pending-on-LIVE
Pending-on-STAGING
Seen-on-STAGING
and removed
Pending-on-STAGING
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hot-fixed to live without fully understanding the problem so users were unblocked.
The problem was I tested #1369 as an audit team member who have short circuit permission to do any edits.
Testing as a lead clinician revealed that it crashed confirming eligibility or any other operations on a blank registration (created on demand when first loading the register page).
The test of course passes as the fix worked but adding it for posterity.
Closes #1373