Some aesthetic changes to make it more user friendly#3
Open
SayantanScience wants to merge 2 commits intorctcwyvrn:masterfrom
Open
Some aesthetic changes to make it more user friendly#3SayantanScience wants to merge 2 commits intorctcwyvrn:masterfrom
SayantanScience wants to merge 2 commits intorctcwyvrn:masterfrom
Conversation
That should be IllegalArgumentException as the argument is illegal, not the internal state. The value key len should be public, or how would one know what is the key length without risking an uncaught exception? And changing method return values to Blake3 inspires more fluent design
|
commit 26644be will cause a NPE later actually. cvStackLen must be decreased first in order to get the correct index, so it should be |
Author
|
Actually its much better to use the java.util.Stack<int[]> class and you get all those memory management for free. That's what I did while implementing Blake3 myself. And yes your point is correct. I was really not that careful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That should be IllegalArgumentException as the argument is illegal, not the internal state. The value key len should be public, or how would one know what is the key length without risking an uncaught exception? And changing method return values to Blake3 inspires more fluent design