-
Notifications
You must be signed in to change notification settings - Fork 13
Issue #45: Add missing spec methods to DataFactory interface #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b0ca1a9
Add missing spec methods to DataFactory interface
matthieubosquet 14906cf
Use changeset instead of changelog
matthieubosquet 1bc8695
Apply suggestions from code review
matthieubosquet f1879fb
Fix fromTerm tests
matthieubosquet cfc4d28
Apply jeswr suggestion
matthieubosquet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ | |
|
||
const namedNodeConstant: NamedNode<'http://example.org'> = <any> {}; | ||
const constantIri: 'http://example.org' = namedNodeConstant.value; | ||
// @ts-expect-error | ||
Check warning on line 22 in rdf-js-tests.ts
|
||
const otherConstantIri: 'http://not-example.org' = namedNodeConstant.value; | ||
// @ts-expect-error | ||
const otherNamedNodeConstant: NamedNode<'http://not-example.org'> = namedNodeConstant; | ||
|
@@ -84,6 +84,21 @@ | |
|
||
const variable: Variable = dataFactory.variable ? dataFactory.variable('v1') : <any> {}; | ||
|
||
const defaultGraph: DefaultGraph = dataFactory.defaultGraph(); | ||
|
||
const term1: Term = dataFactory.fromTerm(dataFactory.namedNode("")); | ||
const term2: Term = dataFactory.fromTerm(dataFactory.blankNode()); | ||
const term3: Term = dataFactory.fromTerm(dataFactory.literal("")); | ||
const term4: Term = dataFactory.fromTerm(dataFactory.variable ? dataFactory.variable("v1") : <any> {}); | ||
const term5: Term = dataFactory.fromTerm(dataFactory.defaultGraph()); | ||
matthieubosquet marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
const quadFromQuad: Term = dataFactory.fromQuad(dataFactory.quad( | ||
dataFactory.namedNode("x"), | ||
dataFactory.namedNode("y"), | ||
dataFactory.literal(""), | ||
dataFactory.defaultGraph() | ||
)); | ||
|
||
const term: NamedNode = <any> {}; | ||
interface QuadBnode extends BaseQuad { | ||
subject: Term; | ||
|
@@ -119,6 +134,8 @@ | |
const equalToSelf: boolean = quadBobAge2.equals(quadBobAge); | ||
const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else')); | ||
} | ||
|
||
const quadTerm: Term = dataFactory.fromTerm(quadBobAge); | ||
matthieubosquet marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} | ||
|
||
function test_datafactory_star_basequad() { | ||
|
@@ -143,6 +160,10 @@ | |
const equalToSelf: boolean = quadBobAge2.equals(quadBobAge); | ||
const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else')); | ||
} | ||
|
||
const baseQuadTerm: Term = dataFactory.fromTerm(quadBobAge); | ||
matthieubosquet marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
const baseQuad: BaseQuad = dataFactory.fromQuad(quadBobAge); | ||
} | ||
|
||
function test_stream() { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.