Skip to content

Update for multiple snapshot OSTRICH#24

Open
opelgrin wants to merge 81 commits intordfostrich:masterfrom
dkw-aau:master
Open

Update for multiple snapshot OSTRICH#24
opelgrin wants to merge 81 commits intordfostrich:masterfrom
dkw-aau:master

Conversation

@opelgrin
Copy link

This PR includes the done during my PhD to support multiple snapshots OSTRICH.

opelgrin and others added 30 commits June 9, 2022 10:15
@opelgrin opelgrin changed the title Versioning update for multiple snapshot OSTRICH Update for multiple snapshot OSTRICH Oct 21, 2024
@rubensworks
Copy link
Member

Thanks @opelgrin, this looks great!

Before I merge, just some small questions:

  1. Did anything change to the JavaScript API that warrant a change to the README? If yes, I'm happy to do this myself, as I know you may not be able to make time for this. But some pointers may help.
  2. It looks like the gitmodules points to your fork of ostrich on branch delta-timestamps, but it appears this branch does not exist on github. Is it one that still needs to be pushed? Or is https://github.com/rdfostrich/ostrich/ on the master branch already up-to-date, and could that one be used instead?

@opelgrin
Copy link
Author

opelgrin commented Oct 24, 2024

Concerning point 1, I believe it works with Node 18 but not newer versions (and probably older versions as well, but I didn't test it). The Javascript API tend to be unstable for native addons it seems.
As for point 2, OSTRICH's master branch is up to date and we should use it.

@rubensworks
Copy link
Member

Ok great, thanks @opelgrin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants