VPLAY-11225 [Tech Debt] mediafailed event enhancements ( minor code etc )

Reason for change: Added minor code for MediaFailedEvent
Risks: Low
Test Procedure: Refer jira ticket
Priority: P1

Signed-off-by: lashmintha <[email protected]>

Author: lashmintha

AAMP-UVE-API.md

@@ -2463,8 +2463,8 @@ When a player instance is no longer needed, recommend to call explicit release()
 | AAMP_TUNE_GST_PIPELINE_ERROR | 80 | 8001 | AAMP: Error from gstreamer pipeline |
 | AAMP_TUNE_FAILED_PTS_ERROR | 80 | 8002 | AAMP: Playback failed due to PTS error |
 
-| AAMP_TUNE_PLAYBACK_STALLED | 7600 | 0 | AAMP: Playback was stalled due to lack of new fragments |
-| AAMP_TUNE_FAILURE_UNKNOWN | 100 | 0 | AAMP: Unknown Failure |
+| AAMP_TUNE_PLAYBACK_STALLED | 7600 | 1 | AAMP: Playback was stalled due to lack of new fragments |
+| AAMP_TUNE_FAILURE_UNKNOWN | 100 | 1 | AAMP: Unknown Failure |
 
 ---
 

priv_aamp.cpp

@@ -238,10 +238,10 @@ static TuneFailureMap tuneFailureMap[] =
 	{AAMP_TUNE_FAILED_PTS_ERROR, 80, 8002, "AAMP: Playback failed due to PTS error"},
 
 	//Playback failure
-	{AAMP_TUNE_PLAYBACK_STALLED, 7600, 0, "AAMP: Playback was stalled due to lack of new fragments"},
+	{AAMP_TUNE_PLAYBACK_STALLED, 7600, 1, "AAMP: Playback was stalled due to lack of new fragments"},
 
 	//Unknown failure
-	{AAMP_TUNE_FAILURE_UNKNOWN, 100, 0, "AAMP: Unknown Failure"}
+	{AAMP_TUNE_FAILURE_UNKNOWN, 100, 1, "AAMP: Unknown Failure"}
 };
 
 static const std::pair<std::string , std::string> gCDAIErrorDetails[] = {

test/utests/tests/AampEventTests/AampEventTests.cpp

@@ -24,6 +24,8 @@
 using namespace testing;
 
 #define EFFECTIVE_URL "http://manifest.mpd"
+#define TUNE_FAILURE_UNKNOWN_MAJOR 100
+#define TUNE_FAILURE_UNKNOWN_MINOR 1
 
 class AAMPEventTests : public ::testing::Test {
 protected:
@@ -82,7 +84,7 @@ class MediaErrorEventTest : public testing::Test{
 protected:
 
     void SetUp() override {
-        errorEvent = new MediaErrorEvent(AAMP_TUNE_FAILURE_UNKNOWN,100,10001,"Test",false,0,0,0,"", session_id);
+        errorEvent = new MediaErrorEvent(AAMP_TUNE_FAILURE_UNKNOWN,TUNE_FAILURE_UNKNOWN_MAJOR,TUNE_FAILURE_UNKNOWN_MINOR,"Test",false,0,0,0,"", session_id);
     }
     void TearDown() override {
         delete errorEvent;
@@ -120,7 +122,7 @@ TEST_F(MediaErrorEventTest, MediaErrorEventMethodsanotherTest) {
 
     EXPECT_EQ(errorEvent->getFailure(), AAMPTuneFailure::AAMP_TUNE_FAILURE_UNKNOWN);
     EXPECT_EQ(errorEvent->getCode(), 100);
-    EXPECT_EQ(errorEvent->getMinorCode(), 10001);
+    EXPECT_EQ(errorEvent->getMinorCode(), 1);
     EXPECT_EQ(errorEvent->getDescription(), "Test");
     EXPECT_EQ(errorEvent->getResponseData(), "");
     EXPECT_FALSE(errorEvent->shouldRetry());